Feature: Forgot password by vishesh92 · Pull Request #9509 · apache/cloudstack

vishesh92 · 2024-08-09T09:21:12Z

Docs PR: apache/cloudstack-documentation#432

Description

This PR adds the functionality to reset password for a user by email.

8 Global settings:

Category	Type	Name	Default value	Description	Dynamic
Advanced	Long	`password.reset.ttl`	30	Password reset ttl in minutes	Yes
Advanced	String	`password.reset.email.sender`	`null`	Password reset email sender	Yes
Advanced	String	`password.reset.smtp.host`	`null`	Password reset smtp host	No
Advanced	Integer	`password.reset.smtp.port`	25	Password reset smtp port	No
Advanced	Boolean	`password.reset.smtp.useAuth`	`False`	Use auth for smtp in Password reset	No
Advanced	String	`password.reset.smtp.username`	`null`	Password reset smtp username	No
Secure	String	`password.reset.smtp.password`	`null`	Password reset smtp password	No
Advanced	String	`password.reset.mail.template`	Hello {{username}}!\nYou have requested to reset your password. Please click the following link to reset your password:\n{{{reset_link}}}\nIf you did not request a password reset, please ignore this email.\n\nRegards,\nThe CloudStack Team	Password reset mail template. This uses mustache template engine. Available variables are: username, firstName, lastName, resetLink, token	Yes

2 new APIs:

Command: forgotPassword
Params: username, domain
Details: Sends an email to the user with a token which can be used to reset the password using resetPassword command.
Command: resetPassword
Params: username, domain, token, password
Details: Resets the password for the user using the token generated via forgotPassword command.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

How Has This Been Tested?

Setup a mailserver or for testing purposes use the below command to setup maildev using docker

docker run -d -p 1080:1080 -p 1025:1025 maildev/maildev

Update the above global settings to point the smtp host to the above docker container and restart the management server.
Ensure an email is set for the test user
In UI, click on forgot password and enter details.
maildev runs a web ui to view all emails being sent. Open maildev's UI which is running on port 1080 and see if there are any emails.
There should be an email from cloudstack to reset the password for the user. Click on the link in the email to reset the password or copy the token.
Open the link in the email or navigate to {ACS MS}/user/resetPassword on the UI.
Enter the details along with token from the email. Set the new password.
Try login with the newly set password.

How did you try to break this feature and the system with this change?

codecov · 2024-08-09T09:32:40Z

Codecov Report

Attention: Patch coverage is 28.30769% with 233 lines in your changes missing coverage. Please review.

Project coverage is 15.76%. Comparing base (8c8d115) to head (b3ffbf3).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
.../cloudstack/user/UserPasswordResetManagerImpl.java	41.84%	79 Missing and 3 partials ⚠️
.../auth/DefaultResetPasswordAPIAuthenticatorCmd.java	0.00%	69 Missing ⚠️
...auth/DefaultForgotPasswordAPIAuthenticatorCmd.java	0.00%	63 Missing ⚠️
server/src/main/java/com/cloud/api/ApiServer.java	60.60%	12 Missing and 1 partial ⚠️
...m/cloud/api/auth/APIAuthenticationManagerImpl.java	0.00%	3 Missing ⚠️
...ma/src/main/java/com/cloud/user/UserAccountVO.java	0.00%	2 Missing ⚠️
...c/main/java/com/cloud/user/AccountManagerImpl.java	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #9509     +/-   ##
===========================================
  Coverage     15.76%   15.76%             
- Complexity    12510    12524     +14     
===========================================
  Files          5621     5627      +6     
  Lines        491469   491884    +415     
  Branches      62967    60293   -2674     
===========================================
+ Hits          77460    77544     +84     
- Misses       405553   405878    +325     
- Partials       8456     8462      +6

Flag	Coverage Δ
uitests	`4.03% <ø> (-0.02%)`	⬇️
unittests	`16.58% <28.30%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vishesh92 · 2024-08-13T08:02:14Z

@blueorangutan package

blueorangutan · 2024-08-13T08:04:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-13T09:13:20Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10631

vishesh92 · 2024-08-13T10:07:31Z

@blueorangutan test

blueorangutan · 2024-08-13T10:08:03Z

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-08-14T01:41:39Z

[SF] Trillian test result (tid-11068)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53619 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9509-t11068-kvm-ol8.zip
Smoke tests completed. 138 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	`Failure`	457.46	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	320.12	test_vpc_vpn.py

vishesh92 · 2024-09-06T06:49:12Z

@blueorangutan package

blueorangutan · 2024-09-06T06:50:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-06T08:01:24Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11028

vishesh92 · 2024-09-06T10:16:16Z

@JoaoJandre This feature is behind a flag to enable or disable the password recovery workflow. By default, it's disabled. Can we include this PR in 4.20 release as well?

vishesh92 · 2024-09-06T11:45:51Z

@blueorangutan test

blueorangutan · 2024-09-06T11:48:04Z

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

JoaoJandre · 2024-09-06T12:18:02Z

@JoaoJandre This feature is behind a flag to enable or disable the password recovery workflow. By default, it's disabled. Can we include this PR in 4.20 release as well?

@vishesh92 same as #9633 (comment) :)

blueorangutan · 2024-09-06T21:14:49Z

[SF] Trillian Build Failed (tid-11418)

blueorangutan · 2024-09-07T13:04:41Z

[SF] Trillian Build Failed (tid-11420)

vishesh92 · 2024-09-08T12:14:23Z

@blueorangutan test

blueorangutan · 2024-09-08T12:16:03Z

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-09-08T13:09:23Z

[SF] Trillian Build Failed (tid-11421)

vishesh92 · 2024-09-09T05:16:08Z

@blueorangutan package

blueorangutan · 2024-09-09T05:18:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-09T06:21:45Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11050

vishesh92 · 2024-09-09T06:28:42Z

@blueorangutan test

blueorangutan · 2024-09-09T06:30:04Z

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

borisstoyanov · 2024-09-09T09:08:37Z

@blueorangutan help

blueorangutan · 2024-09-09T09:10:04Z

@borisstoyanov [SL] I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups]
Mgmt OS options: ['ol8', 'ol9', 'alma8', 'alma9', 'suse15', 'centos7', 'centos6', 'rocky8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'ubuntu24']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-ol8', 'kvm-ol9', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'vmware-80u2', 'vmware-80u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu.
When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced)
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar']

blueorangutan · 2024-09-09T21:37:24Z

[SF] Trillian test result (tid-11422)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52163 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9509-t11422-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	134.18	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	134.18	test_vm_life_cycle.py

borisstoyanov

LGTM, manually tested it.

yadvr · 2024-09-10T11:41:30Z

@JoaoJandre @DaanHoogland are we accepting feature PRs now? This is ready for merging and has been reviewed & manually tested.

JoaoJandre · 2024-09-10T12:32:13Z

LGTM, manually tested it.

@borisstoyanov Could you share what tests were done?

borisstoyanov · 2024-09-10T13:08:24Z

sure @JoaoJandre, both positive/negative scenarios, as well with different sub-domains accounts. Also verified the token cannot be used to change other users pass and basic user discovery prevention where prompts a generic response either having matching user or not. Also there were some polishing comments for the email, it now uses html format and there is a text with hyperlink rather than raw hyperlink as before. I didn't see any issues, have you experienced any?

JoaoJandre · 2024-09-10T14:02:43Z

sure @JoaoJandre, both positive/negative scenarios, as well with different sub-domains accounts. Also verified the token cannot be used to change other users pass and basic user discovery prevention where prompts a generic response either having matching user or not. Also there were some polishing comments for the email, it now uses html format and there is a text with hyperlink rather than raw hyperlink as before. I didn't see any issues, have you experienced any?

@borisstoyanov I have not tested the PR. But it is generally good practice to list the tests done and their steps. Like the PR description does.

* Feature: Forgot password * Address comments * fixups * Make forgot password disabled by default * Apply suggestions from code review * Address comments

boring-cyborg bot added component:api component:build component:networking Python Warning... Python code Ahead! labels Aug 9, 2024

vishesh92 force-pushed the forgot-password branch 2 times, most recently from f24c534 to 61f676c Compare August 9, 2024 10:03

boring-cyborg bot added the component:UI label Aug 9, 2024

vishesh92 force-pushed the forgot-password branch 3 times, most recently from 092390b to 0fc1cea Compare August 11, 2024 15:51

apache deleted a comment from blueorangutan Aug 11, 2024

vishesh92 force-pushed the forgot-password branch from 0fc1cea to c665a2f Compare August 11, 2024 16:36

apache deleted a comment from blueorangutan Aug 11, 2024

vishesh92 force-pushed the forgot-password branch from c665a2f to b0bf666 Compare August 12, 2024 19:33

apache deleted a comment from blueorangutan Aug 12, 2024

apache deleted a comment from blueorangutan Aug 13, 2024

vishesh92 force-pushed the forgot-password branch from b0bf666 to 51a721c Compare August 13, 2024 06:48

Feature: Forgot password

a5df0af

vishesh92 force-pushed the forgot-password branch from 51a721c to a5df0af Compare August 13, 2024 06:52

github-actions bot added the status:has-conflicts label Aug 20, 2024

github-actions bot removed the status:has-conflicts label Sep 6, 2024

vishesh92 marked this pull request as ready for review September 6, 2024 11:40

borisstoyanov approved these changes Sep 10, 2024

View reviewed changes

JoaoJandre merged commit 0655075 into apache:main Sep 10, 2024

DaanHoogland deleted the forgot-password branch September 11, 2024 07:23

Conversation

vishesh92 commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

8 Global settings:

2 new APIs:

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vishesh92 commented Aug 13, 2024

Uh oh!

blueorangutan commented Aug 13, 2024

Uh oh!

blueorangutan commented Aug 13, 2024

Uh oh!

vishesh92 commented Aug 13, 2024

Uh oh!

blueorangutan commented Aug 13, 2024

Uh oh!

blueorangutan commented Aug 14, 2024

Uh oh!

vishesh92 commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

vishesh92 commented Sep 6, 2024

Uh oh!

vishesh92 commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

JoaoJandre commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 7, 2024

Uh oh!

vishesh92 commented Sep 8, 2024

Uh oh!

blueorangutan commented Sep 8, 2024

Uh oh!

blueorangutan commented Sep 8, 2024

Uh oh!

vishesh92 commented Sep 9, 2024

Uh oh!

blueorangutan commented Sep 9, 2024

Uh oh!

blueorangutan commented Sep 9, 2024

Uh oh!

vishesh92 commented Sep 9, 2024

Uh oh!

blueorangutan commented Sep 9, 2024

Uh oh!

borisstoyanov commented Sep 9, 2024

Uh oh!

blueorangutan commented Sep 9, 2024

Uh oh!

blueorangutan commented Sep 9, 2024

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Sep 10, 2024

Uh oh!

JoaoJandre commented Sep 10, 2024

Uh oh!

borisstoyanov commented Sep 10, 2024

Uh oh!

JoaoJandre commented Sep 10, 2024

Uh oh!

vishesh92 commented Aug 9, 2024 •

edited

Loading

codecov bot commented Aug 9, 2024 •

edited

Loading